Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead Based off of Tag Index #52

Closed
dalekunce opened this issue Apr 1, 2015 · 16 comments
Closed

Typeahead Based off of Tag Index #52

dalekunce opened this issue Apr 1, 2015 · 16 comments

Comments

@dalekunce
Copy link

dalekunce commented Apr 1, 2015

Survey grid Street Names

looking at the data we gathered from Zimbabwe I think we should we look into populating some select_one fields with data from the osm file. For instance volunteers were really good about adding street names to building address but often have spelling and/or capitalization errors. Populating the street name field with only those features within a bounding box would help eliminate this problem.

@hallahan
Copy link
Contributor

hallahan commented Apr 1, 2015

Wouldn't this require us to assume that there are correct street names already in the OSM file? What if we want something different than what is in the OSM file?

@dalekunce
Copy link
Author

It does assume the roads are correct. So we would need to have an "other" option that allows a free text field.

@hallahan
Copy link
Contributor

hallahan commented Apr 1, 2015

I'm thinking we should have a "Constraint Sprint" that focuses on adding constraint functionality like #40 #21 #20 #17

In fact, could you add an issue tag for constraints so we can isolate these issues for a specific sprint / feature branch?

@hallahan
Copy link
Contributor

hallahan commented Jan 5, 2016

What if we had a constraint where we read and index values of a tag from the main source OSM file?

Rather than have multiple choice UI, we could have a typeahead. For this use case, we could index key name on all of the ways with the tag of highway.

Typeahead might make a bit more sense, because we might have quite a few tags we want to have indexed.

@hallahan
Copy link
Contributor

hallahan commented Jan 5, 2016

Should we rename this Typeahead Based off of Tag Index?

@hallahan hallahan mentioned this issue Jan 5, 2016
@hallahan
Copy link
Contributor

hallahan commented Jan 5, 2016

AutoCompleteTextView looks perfect for our needs. You just feed it with an array of strings for autocomplete.

autocomplete

@hallahan
Copy link
Contributor

hallahan commented Jan 5, 2016

An option that might be simpler than specifying which tags to index for autocomplete is to just do this automatically for everything parsed with the same tag key.

For example, I think the current StringTagValue widget should do this. If it is for a tag of the key name, we should look at everything parsed from source OSM as well as previous responses with the tag key of name. Provide autocomplete suggestions based off of that.

@hallahan hallahan added the P2 label Apr 6, 2016
@hallahan hallahan changed the title Survey grid Street Names Typeahead Based off of Tag Index May 11, 2016
@hallahan
Copy link
Contributor

Yes, we want to seed the autocomplete array with everything parsed for the same tag key, but we also want to be able to correlate one key to the value of another element with a certain key.

For example:

When tagging a building, we want a typeahead for addr:street to refer to the name of all of the highways parsed.

This one will be a huge time saver.

@dalekunce
Copy link
Author

iD already does this and its awesome.

@hallahan
Copy link
Contributor

Looking at this feature and the limited time I have to sprint on constraints, I'm going to go with the JOSM approach of having a simple typeahead that autocompletes all tag values parsed. I'm going to put the most recently used values at the front of the array so that if you are, for example, putting in an addr:street over and over again, the latest chosen autocomplete will show up first.

This approach is more generic and will satisfy the use of any text input. Going that extra mile by sorting by spatial operations should be done in a future sprint once this basic functionality is implemented.

@hallahan
Copy link
Contributor

Whoo!!!

2016-05-16 23 27 46

2016-05-16 23 27 53

@hallahan
Copy link
Contributor

82655db

hallahan added a commit that referenced this issue May 17, 2016
@hallahan
Copy link
Contributor

Implemented typeahead auto complete in the custom select one / select multiple inputs as well.

2016-05-17 00 00 45

@dalekunce
Copy link
Author

This is fantastic.

@hallahan
Copy link
Contributor

There's some bug preventing the typeahead from always working. Investigating...

@hallahan hallahan reopened this May 23, 2016
@hallahan
Copy link
Contributor

APK was in inconsistent state, should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants