-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeahead Based off of Tag Index #52
Comments
Wouldn't this require us to assume that there are correct street names already in the OSM file? What if we want something different than what is in the OSM file? |
It does assume the roads are correct. So we would need to have an "other" option that allows a free text field. |
What if we had a constraint where we read and index values of a tag from the main source OSM file? Rather than have multiple choice UI, we could have a typeahead. For this use case, we could index key Typeahead might make a bit more sense, because we might have quite a few tags we want to have indexed. |
Should we rename this Typeahead Based off of Tag Index? |
AutoCompleteTextView looks perfect for our needs. You just feed it with an array of strings for autocomplete. |
An option that might be simpler than specifying which tags to index for autocomplete is to just do this automatically for everything parsed with the same tag key. For example, I think the current StringTagValue widget should do this. If it is for a tag of the key |
Yes, we want to seed the autocomplete array with everything parsed for the same tag key, but we also want to be able to correlate one key to the value of another element with a certain key. For example: When tagging a building, we want a typeahead for This one will be a huge time saver. |
iD already does this and its awesome. |
Looking at this feature and the limited time I have to sprint on constraints, I'm going to go with the JOSM approach of having a simple typeahead that autocompletes all tag values parsed. I'm going to put the most recently used values at the front of the array so that if you are, for example, putting in an This approach is more generic and will satisfy the use of any text input. Going that extra mile by sorting by spatial operations should be done in a future sprint once this basic functionality is implemented. |
This is fantastic. |
There's some bug preventing the typeahead from always working. Investigating... |
APK was in inconsistent state, should be fine. |
Survey grid Street Names
looking at the data we gathered from Zimbabwe I think we should we look into populating some select_one fields with data from the osm file. For instance volunteers were really good about adding street names to building address but often have spelling and/or capitalization errors. Populating the street name field with only those features within a bounding box would help eliminate this problem.
The text was updated successfully, but these errors were encountered: