Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow keyboards with identical layouts to use the same .json layout files #139

Open
leviport opened this issue Jun 24, 2022 · 1 comment
Labels
wishlist Enhancements or fixes not planned for inclusion, but would be nice to have

Comments

@leviport
Copy link
Member

While testing #136, I tried importing my launch_1 layout file for the launch_2, which was not allowed since they have different model names. After copying the .json layout file and changing the model on line to from launch_1 to launch_2, it imported smoothly. That got me thinking, and I tried importing my oryp6 layout onto a gaze16-3050. The same thing happened -- my layout wasn't accepted until I changed the model from oryp6 to gaze16-3050, then it imported without issue and behaved fine.

So I think it would be a nice addition if compatible layouts were cross-importable. If the layout is otherwise identical, then the model name not matching might not always be a good reason for it to refuse to import the layout.

@leviport leviport added the wishlist Enhancements or fixes not planned for inclusion, but would be nice to have label Jun 24, 2022
@ids1024
Copy link
Member

ids1024 commented Jun 27, 2022

This shouldn't be too hard since the layouts were de-duplicated in #60. Though launch_1 and launch_2 currently are separate (identical) layouts because of how it's generated from the QMK source, which doesn't have the same logic for sharing this that EC has since system76/ec#205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Enhancements or fixes not planned for inclusion, but would be nice to have
Projects
None yet
Development

No branches or pull requests

2 participants