Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative admin group list, or perhaps testing access directly instead #81

Open
moll opened this issue Jul 28, 2020 · 0 comments
Open

Comments

@moll
Copy link

moll commented Jul 28, 2020

Hey,

It took me a few moments to realize why exactly Firmware Manager kept showing it's only for administrators. I first traced it down to https://github.com/pop-os/system76-firmware/blob/2a64993c8d7fc10f170f3707846b0221c4313f8a/data/system76-firmware-daemon.conf listing two groups as permitted parties. As I had configured sudo to use a different group than %sudo, I thought adding it to /etc/dbus-1/system.d/system76-firmware-daemon.conf would suffice. Turns out, however, that the permitted group list is also hardcoded into https://github.com/pop-os/firmware-manager/blob/df334aeb2b5e6b9df719ab1f2dddcdb08cdf475e/src/users.rs.

Wouldn't it be more robust to just try passing a DBUS message to FirmwareDaemon and seeing it that works, rather than assuming access based on the group?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant