[P2P][Consensus] Separate Consensus and P2P Private Keys

[jessicadaugherty]

Objective

Separate Consensus and P2P Private Keys to improve the security posture, enable greater flexibility in key management strategies, and isolate the impact of potential key compromises.

Origin Document

ADR-0004

Goals

• Separate private keys for P2P and consensus modules
• Implement a secure and efficient key management strategy for each module
• Ensure the isolation of potential key compromises between the modules

Deliverable

• Update the codebase to use separate private keys for P2P and consensus modules
• Implement secure key management strategies for both modules
• Update related documentation and code comments to reflect the separation of private keys for P2P and consensus modules

Non-goals / Non-deliverables

• Refactoring of the codebase beyond the scope of implementing separate private keys for P2P and consensus modules

General issue deliverables

• Update the appropriate CHANGELOG
• Update any relevant READMEs (local and/or global)
• Update any relevant global documentation & references
• If applicable, update the source code tree explanation
• If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

• All tests: make test_all
• LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

---

Creator: @jessicadaugherty

[Olshansk]

@bryanchriswhite I've left a few comments & questions in pokt-network/pocket-network-protocol#35, so let's resolve those and merge in the ADR to see if/how this should be scoped.