-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polar Plot #7
Comments
Hi @polvalente, polar plots would be definitely welcome here. Probably we would add it to a The code uses VegaLite under the hook, and from a quick look at the current PR the port seems straight forward. You can take a stab on this if you want. A function for appending layers was already in the plans in order to support some other features of the backlog. |
I believe append_layers would still be accepted in VegaLite, even though they're deprecating VegaLite.Data (@josevalim, can you confirm?) Having that available, how would we go about bringing that code in? Would it be a line-by-line port, or would it have to be translated into the Tucan API? I'm also not sure about how part of the API would work with the current code (e.g. coloring only the line layers instead of the grid) |
Correct. |
@polvalente I added |
Are polar plots something that would be welcome here?
I have this PR open on VegaLite, but with the presence of this higher level library, it might be welcome here instead.
The only thing I'm not sure about is that the higher level API might not support the current structuring of the code.
The text was updated successfully, but these errors were encountered: