fix: use provided xhrRequest when loading Potree2 hierarchy and octree #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Potree1 models we are able to provide a custom xhrRequest that is used when requesting any of the resources associated with the model. This is particularly useful when trying to add custom authentication headers to the requests.
Potree2 models are loaded with the same API, however currently the xhrRequest that is passed in is only used for loading the metadata.json file and is not used for fetching the octree.bin or hierarchy.bin files. This means that we cannot use authentication headers for loading these bin files.
This PR is to fix that, so we are able to use custom headers for Potree2 models, the same way we can for Potree1 models.