From 0da102061e65fe78af211dce163abf7ef127b0e3 Mon Sep 17 00:00:00 2001 From: Ken Raffenetti Date: Thu, 2 Jan 2025 11:02:30 -0600 Subject: [PATCH] ch3: Remove unnecessary checks in process group close These checks are not needed and lead to warnings due to set but unused variable. --- src/mpid/ch3/src/mpidi_pg.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/mpid/ch3/src/mpidi_pg.c b/src/mpid/ch3/src/mpidi_pg.c index 5db84999bb9..16902f80e10 100644 --- a/src/mpid/ch3/src/mpidi_pg.c +++ b/src/mpid/ch3/src/mpidi_pg.c @@ -938,7 +938,7 @@ int MPIDI_PG_Close_VCs( void ) MPIR_FUNC_ENTER; while (pg) { - int i, inuse, n, i_start; + int i, n, i_start; MPL_DBG_MSG_S(MPIDI_CH3_DBG_DISCONNECT,VERBOSE,"Closing vcs for pg %s", (char *)pg->id ); @@ -955,10 +955,6 @@ int MPIDI_PG_Close_VCs( void ) vc = &pg->vct[i]; /* If the VC is myself then skip the close message */ if (pg == MPIDI_Process.my_pg && i == MPIDI_Process.my_pg_rank) { - /* XXX DJG FIXME-MT should we be checking this? */ - if (MPIR_Object_get_ref(vc) != 0) { - MPIDI_PG_release_ref(pg, &inuse); - } continue; } @@ -968,12 +964,6 @@ int MPIDI_PG_Close_VCs( void ) MPIR_ERR_CHECK(mpi_errno); } else if (vc->state == MPIDI_VC_STATE_INACTIVE || vc->state == MPIDI_VC_STATE_MORIBUND) { - /* XXX DJG FIXME-MT should we be checking this? */ - if (MPIR_Object_get_ref(vc) != 0) { - /* FIXME: If the reference count for the vc is not 0, - something is wrong */ - MPIDI_PG_release_ref(pg, &inuse); - } /* Inactive connections need to be marked INACTIVE_CLOSED, so that if a connection request comes in during the close protocol, we know to