Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

J2V8 Config from Consumer #576

Merged
merged 2 commits into from
Jan 16, 2025
Merged

J2V8 Config from Consumer #576

merged 2 commits into from
Jan 16, 2025

Conversation

brocollie08
Copy link
Contributor

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@brocollie08 brocollie08 added the patch Increment the patch version when merged label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (cb3ea0c) to head (835661a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   89.76%   89.75%   -0.01%     
==========================================
  Files         331      331              
  Lines       19836    19836              
  Branches     1949     1949              
==========================================
- Hits        17805    17804       -1     
- Misses       2017     2018       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brocollie08 brocollie08 marked this pull request as ready for review January 16, 2025 19:19
@brocollie08 brocollie08 force-pushed the remove-j2v8-config-override branch from 16b7fec to 4a09417 Compare January 16, 2025 19:27
@brocollie08 brocollie08 force-pushed the remove-j2v8-config-override branch from 4a09417 to 835661a Compare January 16, 2025 19:39
@brocollie08 brocollie08 merged commit 1dbe6f3 into main Jan 16, 2025
10 of 11 checks passed
@brocollie08 brocollie08 deleted the remove-j2v8-config-override branch January 16, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants