Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when creating a custom page menu at the site context #10720

Closed
jonasraoni opened this issue Dec 16, 2024 · 2 comments · Fixed by #10723 · May be fixed by pkp/ojs#4562
Closed

Exception when creating a custom page menu at the site context #10720

jonasraoni opened this issue Dec 16, 2024 · 2 comments · Fixed by #10723 · May be fixed by pkp/ojs#4562
Assignees
@jonasraoni
Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Milestone
3.5 Internal

Comments

@jonasraoni
Copy link
Contributor

Describe the bug
It's not possible to use the custom page menus at the site context.

To Reproduce

    1. Create a custom page menu at the site context
      1. Try to click on the preview.
      1. Or add it to the site and try to open the index page.

What application are you using?
main branch

Additional information

Accept null values at the method that you had problems (or do checks/coercions at the calling site)... The line where the exception was raised, including other variables can be dropped, but looks like something is missing. A simple test using a context level menu showed me a couple of other issues, so it's good to review the previous commits on that file.

Originally posted by @jonasraoni in #10578
@jonasraoni jonasraoni added the Bug:2:Moderate A bug that is causing problems for a substantial minority of users. label Dec 16, 2024
@jonasraoni jonasraoni added this to the 3.5 Internal milestone Dec 16, 2024
@jonasraoni jonasraoni self-assigned this Dec 16, 2024
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Dec 16, 2024
@jonasraoni
pkp#10720 Fixed preview button
34258f7
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Dec 16, 2024
@jonasraoni
pkp#10720 Fixed display of custom page menu
bd80a63
@jonasraoni jonasraoni linked a pull request Dec 16, 2024 that will close this issue
Bugfix main 10720 fix navigation menu #10723
Merged
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Dec 16, 2024
@jonasraoni
pkp/pkp-lib#10720 Submodule update ##jonasraoni/bugfix-main-10720-fix…
5094d8c 
…-navigation-menu##
@jonasraoni jonasraoni linked a pull request Dec 16, 2024 that will close this issue
pkp/pkp-lib#10720 TESTS ONLY pkp/ojs#4562
Open
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Dec 16, 2024
@jonasraoni
pkp/pkp-lib#10720 Submodule update ##jonasraoni/bugfix-main-10720-fix…
138b1f0 
…-navigation-menu##
@bozana
Copy link
Collaborator

bozana commented Dec 17, 2024

Hi @jonasraoni, I have just reviewed the PR and it looks good, but I do not know how I can test it 😅 Where/how can I create a custom page menu at the site context?

@kaitlinnewson
Copy link
Member

Hi @jonasraoni, I have just reviewed the PR and it looks good, but I do not know how I can test it 😅 Where/how can I create a custom page menu at the site context?

@bozana If you have 2 or more journals setup in the instance, then it appears in Administration > Site Settings > Navigation

jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Dec 17, 2024
@jonasraoni
Revert "pkp#10720 Fixed preview button"
852f0e2 
This reverts commit 34258f7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
Bug:2:Moderate A bug that is causing problems for a substantial minority of users.
Projects
None yet
Milestone
3.5 Internal
3 participants
@jonasraoni @bozana @kaitlinnewson