Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary avo dependency #148

Closed
mmcloughlin opened this issue Jan 17, 2025 · 1 comment · Fixed by #149
Closed

Unnecessary avo dependency #148

mmcloughlin opened this issue Jan 17, 2025 · 1 comment · Fixed by #149

Comments

@mmcloughlin
Copy link
Contributor

The sha1cd module has an unnecessary dependency on avo, since avo is only required for code-generation. It seems this has caused problems for sha1cd users:

sourcegraph/zoekt#893
mmcloughlin/avo#455

A common pattern for avo code generators is to use a separate module. The Go standard library calls these _asm, for example:

https://github.com/golang/go/blob/80bf7d83edbb48e2411d755f0636565467bb5a56/src/crypto/md5/_asm/go.mod

Other projects call it asm or avo.

@mmcloughlin
Copy link
Contributor Author

PR #149 shows an example of how this could be fixed. It gets the job done but might need some additional cleanup, for example the shared module perhaps does not make sense with this arrangement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant