Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag Plugin Gaps: check for CMD(meta) key to avoid page scrolling #492

Open
imabp opened this issue Jul 12, 2024 · 1 comment
Open

Drag Plugin Gaps: check for CMD(meta) key to avoid page scrolling #492

imabp opened this issue Jul 12, 2024 · 1 comment

Comments

@imabp
Copy link

imabp commented Jul 12, 2024

Problem:

Proposal is to change the condition

FROM: (Current Implementation)
if (!wheel || (!wheel.options.wheelZoom && !event.ctrlKey))

TO: (Proposed Condition)
if (!wheel || (!wheel.options.wheelZoom && !(event.ctrlKey || event.metaKey)))

Thanks.
A kind request to @davidfig , other respected contributors, maintainers to check the problem statement and their thoughts on it.

@imabp imabp changed the title Drag Plugin Gaps: check for meta key to avoid page scrolling Drag Plugin Gaps: check for CMD(meta) key to avoid page scrolling Jul 12, 2024
@imabp
Copy link
Author

imabp commented Jul 17, 2024

@ShukantPal @davidfig @Aeolun please check this requirement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant