Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style review #3 #14

Open
12 of 15 tasks
Robertght opened this issue Jun 28, 2017 · 0 comments
Open
12 of 15 tasks

Style review #3 #14

Robertght opened this issue Jun 28, 2017 · 0 comments
Assignees

Comments

@Robertght
Copy link
Contributor

Robertght commented Jun 28, 2017

De la George avem urmatoarele:

General

  • Screenshot-ul temei e de la versiunea cu meniu in stanga.
  • Social Menu e folosit undeva? Ar trebui scos din backend daca nu.

Home Page
Hero

  • Spatierile continutului sunt diferite: https://cl.ly/3M0Q3u2y1i0u (intre meta/buton si titlu cred ca-i mai armonios sa fie aceeasi spatiere)
  • Textul de pe buton are un weight mai mic
  • Butonanele au un efect de hover prea subtil — probabil ar putea ca background-ul sa se faca negru

Arhiva

  • Spatierile in cadrul unui card sunt marite: https://cl.ly/10050u063n15
  • Font-ul continutului e cam subtire → probabil merge setat cu weight: 300
  • Cand sunt mai multe categorii, nu sunt delimitate prea bine. Ori putem pune o virgula din CSS, ori spatiate mai mult: https://cl.ly/263Z3I2k1g2M

Single
Hero

  • Imaginea nu face Fill si nu se centreaza (acum e aliniata top) — de verificat daca sunt aplicate corect regulile de object-fit

Continut

Category

  • Pe pagina unei categorii lipseste titlul acelei categorii si primul post are un spatiu ciudat: https://cl.ly/243q2O033Q0D — poate am putea prelua layout-ul de single si in header sa punem titlul categoriei
Robertght pushed a commit that referenced this issue Jun 28, 2017
Robertght pushed a commit that referenced this issue Jun 28, 2017
Robertght pushed a commit that referenced this issue Jun 28, 2017
Robertght pushed a commit that referenced this issue Jul 4, 2017
Robertght pushed a commit that referenced this issue Jul 4, 2017
Robertght pushed a commit that referenced this issue Jul 4, 2017
Robertght pushed a commit that referenced this issue Jul 4, 2017
Robertght pushed a commit that referenced this issue Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants