Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LicenseFinder does not work with gradle 7 #821

Open
ohlookadollar opened this issue Apr 9, 2021 · 8 comments
Open

LicenseFinder does not work with gradle 7 #821

ohlookadollar opened this issue Apr 9, 2021 · 8 comments

Comments

@ohlookadollar
Copy link
Member

Gradle 7 is deprecating "compile" in favour of "implementation" instead.

The compile configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the implementation or api configuration instead. Consult the upgrading guide for further information: https://docs.gradle.org/6.8.3/userguide/upgrading_version_5.html#dependencies_should_no_longer_be_declared_using_the_compile_and_runtime_configurations

As folks move to gradle 7, they will not be able to use the hierynomus license finder plugin due to issue 182. It's been open for about a year and has not gain any traction.

There are a few more error warning of deprecation:

Property 'html' has redundant getters: 'getHtml()' and 'isHtml()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'ignoreFatalParseErrors' has redundant getters: 'getIgnoreFatalParseErrors()' and 'isIgnoreFatalParseErrors()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'includeProjectDependencies' has redundant getters: 'getIncludeProjectDependencies()' and 'isIncludeProjectDependencies()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'json' has redundant getters: 'getJson()' and 'isJson()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'reportByDependency' has redundant getters: 'getReportByDependency()' and 'isReportByDependency()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'reportByLicenseType' has redundant getters: 'getReportByLicenseType()' and 'isReportByLicenseType()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'xml' has redundant getters: 'getXml()' and 'isXml()'. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.8.3/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@pivotal-pmital
Copy link
Contributor

We're investigating into some other gradle plugins that can return dependencies and licenses for a gradle project. We're currently looking into cyclonedx-gradle-plugin as an alternative to the hierynomous gradle plugin. But we're open to using other gradle plugins that would be relatively easy to integrate into LicenseFinder.

Our current thought process is to add a new parameter (like --gradle-plugin=cyclonedx) that allows users to select which gradle plugin they want to use for their scan. But it would default to the hierynomous gradle plugin so it doesn't break the current users.

Does anybody have other well-maintained gradle plugin suggestions or gradle expertise?

@thedarkside
Copy link

With hierynomus/license-gradle-plugin#191 it should be working now i think. LicenseFinder just has to include the latest release.

@fat-fellow
Copy link

https://github.com/cloudflightio/license-gradle-plugin

https://github.com/jk1/Gradle-License-Report

hierynomus/license-gradle-plugin#213

the hierynomus's project looks a bit unmaintained

@gigaSproule
Copy link
Contributor

gigaSproule commented Sep 29, 2023

This issue can be closed, as we are using Gradle 7, but as @fat-fellow points out, the existing project is not being maintained. @pivotal-pmital any update on what the plan is going forward, considering this has been known for a couple of years to not be suitably maintained?

@gigaSproule
Copy link
Contributor

@xtreme-shane-lattanzio Not sure if you're the right person to ping, but you seem to be more active on this repo. Any thoughts on this?

@gigaSproule
Copy link
Contributor

I've released a forked version of hierynomus license finder plugin's master for anyone else who needs the latest version.

  id("com.benjaminsproule.license") version "0.16.2"
  id("com.benjaminsproule.license-base") version "0.16.2"
  id("com.benjaminsproule.license-report") version "0.16.2"

@xtreme-shane-lattanzio
Copy link
Contributor

Hey @gigaSproule ! We are very short on resources to maintain this at the moment. I am okay with changing the plugin to something else or you forked version but someone will need to make a PR for it and then we can get the fix in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants