Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to get permissions to create bookmarks. #238

Open
Berni11 opened this issue Sep 24, 2020 · 2 comments
Open

Failed to get permissions to create bookmarks. #238

Berni11 opened this issue Sep 24, 2020 · 2 comments
Labels

Comments

@Berni11
Copy link

Berni11 commented Sep 24, 2020

Short description

When I select "Bookmark Tab" I get the following error message "Failed to get permissions to create bookmarks. Please click here to grant the permission." But nothing happens when you click on the dialogue.

Steps to reproduce

  1. Start Firefox with clean profile.
  2. Install MTH.
  3. Open any url. I used the addon website.
  4. Open MTH and right click on a tab.
  5. Select "Bookmark Tab"

Tested on Firefox 80.0.1 (my old profile) and 81 (fresh new profile).

Expected result

A bookmark for the tab should be created.

Actual result

You get a message with the text "Failed to get permissions to create bookmarks. Please click here to grant the permission."

Environment

  • Platform (OS): Windows 7 Professional
  • Version of Firefox: 81
  • Version (or revision) of Multiple Tab Handler: 3.1.8
@Berni11
Copy link
Author

Berni11 commented Sep 24, 2020

Just as a note: When you go to the add-on settings and grant there the permisson for bookmarks everything works fine. Therefore this issue is only for the non functional dialogue which appears when the permission is not yet set.

@piroor
Copy link
Owner

piroor commented Sep 28, 2020

Thanks! I completely forgot to define the default timeout, thus "onClicked" handler is unexpectedly unregistered immediately. This is the reason why the notification popup does nothing when clicked. The commit 5cc5277 should solve the problem: now clicked notification opens MTH's options page for the checkbox to request the "Bookmarks" permission.

@piroor piroor added the fixed label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants