Add optional username and email fields to repo for commits #5477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds username and email fields to the repo struct.
Why we need it:
We need these fields to do the git commit.
Originally, these fields are set when creating the new repo in the git client's Clone method.
When I implemented the CopyToModify method, I forgot to set these fields.
ref;
pipecd/pkg/git/client.go
Lines 239 to 244 in f7e3bbc
Which issue(s) this PR fixes:
Without this PR, the piped cannot handle the GIT_UPDATE event successfully.
How to reproduce the issue
Remove global git config, run piped, and send the event with pipectl.
You will see the log like below.
Does this PR introduce a user-facing change?: