Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin registry #5466

Closed
wants to merge 20 commits into from
Closed

Add plugin registry #5466

wants to merge 20 commits into from

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jan 6, 2025

What this PR does:

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

ffjlabo added 18 commits January 6, 2025 13:56
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 52.88462% with 49 lines in your changes missing coverage. Please review.

Project coverage is 26.20%. Comparing base (602bf8c) to head (0681f93).

Files with missing lines Patch % Lines
pkg/plugin/registry/registry.go 67.74% 20 Missing ⚠️
pkg/app/pipedv1/controller/planner.go 41.66% 10 Missing and 4 partials ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 11 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 3 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5466      +/-   ##
==========================================
+ Coverage   26.15%   26.20%   +0.05%     
==========================================
  Files         457      458       +1     
  Lines       49111    49172      +61     
==========================================
+ Hits        12843    12885      +42     
- Misses      35246    35263      +17     
- Partials     1022     1024       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo
Copy link
Member Author

ffjlabo commented Jan 7, 2025

It's too large, so I will split this PR.

@ffjlabo ffjlabo closed this Jan 7, 2025
@ffjlabo ffjlabo deleted the add-plugin-registry branch January 7, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant