Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must handle plan preview workflow's error and exit with error status code #4661

Closed
TakumaKurosawa opened this issue Nov 8, 2023 · 1 comment · Fixed by #4662
Closed

Must handle plan preview workflow's error and exit with error status code #4661

TakumaKurosawa opened this issue Nov 8, 2023 · 1 comment · Fixed by #4662
Labels
kind/enhancement New feature or request

Comments

@TakumaKurosawa
Copy link
Contributor

What would you like to be added:
Handle plan-preview workflow's error and exit with error status code.

Why is this needed:
Plan preview workflow comments error message but CI workflow passed.
It makes us very confused.

Screenshot_2023-11-08_at_16_40_17
@TakumaKurosawa TakumaKurosawa added the kind/enhancement New feature or request label Nov 8, 2023
@TakumaKurosawa TakumaKurosawa mentioned this issue Nov 8, 2023
Merged
@TakumaKurosawa
Copy link
Contributor Author

I'd like to work on this.
I've already make PR: #4662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle plan preview workflow's error and exit with error status code TakumaKurosawa/pipecd
1 participant
@TakumaKurosawa