Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sample app] AsyncTask or UI Thread Okay? #160

Closed
js-commit opened this issue Sep 23, 2019 · 2 comments
Closed

[sample app] AsyncTask or UI Thread Okay? #160

js-commit opened this issue Sep 23, 2019 · 2 comments

Comments

@js-commit
Copy link

According to the docs, read/write operations should happen in a non-UI thread like an AsyncTask.

However, the sample app show it's in the UI thread.

Can we get away with calling read/write in the UI Thread (for ex. an activity)?
@pilgr
Copy link
Owner

pilgr commented Sep 23, 2019

Yeah, thanks for pointing that out, it should be done differently. The app has never been referenced as sample app but some people may look into it so it's better be fixed.

@pilgr pilgr changed the title AsyncTask or UI Thread Okay? [sample app] AsyncTask or UI Thread Okay? Nov 15, 2019
@pilgr pilgr mentioned this issue Feb 29, 2020
Merged
@pilgr
Copy link
Owner

pilgr commented Feb 29, 2020

I've added async tasks to the sample app in PR #168 It was so fun to write it in 2020 😄

@pilgr pilgr closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pilgr @js-commit