Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with M1 Mac 🍎 💻 #79

Closed
6 of 7 tasks
pietrop opened this issue Jul 26, 2021 · 2 comments
Closed
6 of 7 tasks

Compatibility with M1 Mac 🍎 💻 #79

pietrop opened this issue Jul 26, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Owner

pietrop commented Jul 26, 2021

So far these seems to be the stepped involved

  1. At the moment deepspeech-node-wrapper uses sox-bin as a dependency, and it seems like the binary is not compatible with M1 architecture, see issue Mac OS X M1 ArtskydJ/node-sox-bin#8
    1. maybe the module could be refactored deepspeech-node-wrapper/src/index.js to not use sox-bin but ffmpeg instead? 🤷‍♂️ 🤔 ❓
    2. for now might be easier to remove deepspeech-node-wrapper and bring it back later, perhaps with added support for Coqui 🐸 when their nod release becomes available.
  2. possibly ffmpeg-static-electron binary might need updating to M1 - eg either the binary and/or the arch folder structure for electron arm64
  3. ffprobe-static-electron
  4. dialog can no longer be required from render remote process, only from main process, so need to use ipc
    1. electron needs to be update to version > 11
  5. electron builder might need updating?
  6. travis.org has changed their workflow by requiring to switch to travis.com, might be worth either migrating or switching to github actions.
  7. ... ?

@pietrop pietrop added the bug Something isn't working label Jul 26, 2021
@pietrop pietrop self-assigned this Jul 26, 2021
@pietrop pietrop pinned this issue Jul 26, 2021
@pietrop pietrop changed the title Compatibility with M1 Mac Compatibility with M1 Mac 🍎 💻 Jul 26, 2021
@pietrop
Copy link
Owner Author

pietrop commented Jul 26, 2021

@pietrop
Copy link
Owner Author

pietrop commented Aug 24, 2021

addressed in PR #80

  • Switched to github actions
  • removed deepspeech for M1 macs while pockesphinx it's not compatible, might bring back later

@pietrop pietrop closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant