Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch mode launches simultaneous ffmpeg transcodes for all files instead of processing them sequentially #73

Open
motioncircus opened this issue May 2, 2021 · 12 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@motioncircus
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to New Batch Transcripts
  2. Click on the above
  3. Add multiple source files
  4. Got to Task Manager and look at the amount of ffmpeg instances competing for your CPU and RAM

Expected behavior
Sequential processing of ONE or A FEW files at a time, not 35 like I saw yesterday

AutoEdit 3-1.4.0

Desktop (please complete the following information):

  • OS: WIN10 Pro 64 bit
  • Browser chrome
  • Version 10.0.19042 Build 19042
@motioncircus motioncircus added the bug Something isn't working label May 2, 2021
@pietrop
Copy link
Owner

pietrop commented May 2, 2021

Hi @motioncircus,
Thanks for flagging this.

The batch import it's somewhat of an experimental feature. The blocker I have with this one, is that I need to figure out a way to stagger or queue the requests in javascript/node/electron.

For context, It was initially introduced here pietrop/digital-paper-edit-client#16

Looking at the code. As it is now, the problem is mostly on the client. where it takes the list of files and pietrop/digital-paper-edit-client/src/Components/Transcripts/BatchTranscriptForm.js#L98 and call pietrop/digital-paper-edit-client/src/Components/Transcripts/BatchTranscriptForm.js#L110 using a forEach loop.

So I guess if I could find a good way to add a queue, I could add it at that stage.

One solution could be to use a for loop and async await as described here on stackoverflow - Using async/await with a forEach loop

@motioncircus
Copy link
Author

motioncircus commented May 2, 2021 via email

@pietrop
Copy link
Owner

pietrop commented May 3, 2021

ah, interesting, what file format are you using for the transcription? (docx, txt etc..)

pietrop pushed a commit to pietrop/digital-paper-edit-client that referenced this issue May 3, 2021
@motioncircus
Copy link
Author

motioncircus commented May 3, 2021 via email

@pietrop pietrop added the help wanted Extra attention is needed label May 3, 2021
@pietrop
Copy link
Owner

pietrop commented May 3, 2021

Ok, yeah so this is what I was wondering, do you use the paper-editing view?

See this section of the user manual for how to search across transcripts in a project

And this for more broadly about the paper editing functionalities section

@motioncircus
Copy link
Author

motioncircus commented May 3, 2021 via email

@pietrop
Copy link
Owner

pietrop commented May 3, 2021

ah, no, I had not seen that, do you have a link? I looked through rev.com but can't find it

@motioncircus
Copy link
Author

motioncircus commented May 3, 2021 via email

@motioncircus
Copy link
Author

motioncircus commented May 3, 2021 via email

@motioncircus
Copy link
Author

motioncircus commented May 19, 2021 via email

@pietrop
Copy link
Owner

pietrop commented May 19, 2021

Hi Nigel,
Sorry to hear that.

If you have a mac, then you could just use the mac version of the app (which is the one I use/primarily develop for)

There's a 1.6.0 release coming up shortly in the release section

(More info on installing the Mac OSX version in the user manual, just in case)

This issue tho

the interface quite laggy and the video playback unreliable and the sound strangely reverberant, as if more than
one file is playing back simultaneously but ever so slightly out of sync.

sounds like an issue with the video playback part of the programme script in the paper edit I raised it as a separate issue to look into it separately. pietrop/digital-paper-edit-client#57 I suspect it's a problem with the underlying BBC Video context component which unfortunately is not very actively maintained at the moment. So I'll have to have a think about what could be an effective solution for this.

For now, as far as you could tell, was there a sequence of steps that seemed to be mostly responsible for when this issue of the reverberation comes up?

@motioncircus
Copy link
Author

motioncircus commented May 21, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants