Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail in Windows #5

Closed
JJ opened this issue Sep 2, 2019 · 3 comments
Closed

Tests fail in Windows #5

JJ opened this issue Sep 2, 2019 · 3 comments

Comments

@JJ
Copy link
Collaborator

JJ commented Sep 2, 2019

This refers to #2 but also #1. Check out Appveyor output. Maybe there are similar problems in OSx
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Adds tests to catch Windows error refs #5
3a1ba98
@JJ
Copy link
Collaborator Author

JJ commented Sep 4, 2019

This issue is dicey. I thought it had something to do with Windows paths, but it's more sneaky. It's got to do with file status and/or how it's read from a JSON file. Might be down to JSON::Fast, might not. Who knows...

@JJ JJ mentioned this issue Sep 4, 2019
Open
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Addresses #5 and also #7, that one is tougher
660a389
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Uses (theoretically OS-independent) IO::Path, refs #5
1593516
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Adds file tests refs #5
d497567
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Eliminates unneeded dependencies, also refs #5
8e3bb90
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Eliminates dependencies and also makes dir creation os-independent, r…
e7a5b49 
…efs #5
@JJ
Copy link
Collaborator Author

JJ commented Sep 4, 2019

The problem seems to be deep down in how CompUnit::PrecompilationRepository::Document handles files. That's using mainly very low level primitives from NQP, so that might be tricky.

JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Adds more low-level tests refs #5
387088a
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Comments out unused code
ab4d993 
Closes #8, still refs #5
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Apparently, rmtree was not working.
911b8fe 
This is related to #7, but we are adressing #5
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Avoid windows shell error, refs #5
ea0a082
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Tries again refs #5
38dcc61
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Exploring filesystem, refs #5
ebb70df
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Adds whole path refs #5
897d561
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Trying deltree suggested by @nxadm and xliff #5
35d60f5
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Deltree does not work refs #5
2e3dc48
@JJ
Copy link
Collaborator Author

JJ commented Sep 4, 2019

I think I've finally found what's the problem with Windows. It's basically that the class creates a lock that can't be deleted, and thus the file cache can't be deleted, so we have to work with it. The problem is that we're going to leave a lot of files around in Windows, but I can't see how that can be fixed.

JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Back to normal, tests again #5
ce0663f
@JJ JJ closed this as completed in 6a983e3 Sep 4, 2019
JJ added a commit that referenced this issue Sep 4, 2019
@JJ
Bumps up to 0.4 with Windows fix (#5)
4837cdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JJ