Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value to form_error event #391

Open
prayagd opened this issue Jan 20, 2025 · 6 comments · May be fixed by #396
Open

Add value to form_error event #391

prayagd opened this issue Jan 20, 2025 · 6 comments · May be fixed by #396
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented Jan 20, 2025

As a marketing user, i should see the "Traffic jam" error in the GA whenever it is shown to the user

Todo

  • Add one more DL value to the event form_error in the parameter error_message
  • Value is "digital traffic jam"

Acceptance criteria

  • The above value should be captured in GA whenever it is shown to the user
@prayagd
Copy link
Collaborator Author

prayagd commented Jan 20, 2025

Hey team! Please add your planning poker estimate with Zenhub @ebma @gianfra-t @Sharqiewicz

@prayagd
Copy link
Collaborator Author

prayagd commented Jan 20, 2025

@pendulum-chain/devs what are all the conditions when we show the traffic jam error to the users? Asking because marketing also wants to know the reasons when this error was shown, based on that will make changes if we need to consider more values here

@gianfra-t
Copy link
Contributor

It is based on many things actually, a maybe not exhaustive list is:

  • Signer service is down (due to lack of funds, rate limit, etc)
  • A failure to connect to the Pendulum nodes.
  • (not yet implemented but planned) check for the oracle prices liveliness in Pendulum.

@ebma
Copy link
Member

ebma commented Jan 20, 2025

Let's not call the event parameter "digital traffic jam". How about we use 'initialization error' instead? Also, it might be better not to add this to the existing form_error event but create a new one. The initialization error will most or all of the time be unrelated to the form input so it makes sense to group it separately. For the parameters, I think we @pendulum-chain/devs should add all possible scenarios as a different parameter to the event so we can always be sure what the problem is. For example, for lack of tokens on the funding account, we should make clear in the event if it's a lack on the Stellar or Pendulum funding account, etc.

@gianfra-t gianfra-t self-assigned this Jan 21, 2025
@gianfra-t
Copy link
Contributor

If I understand this correctly, then this new initialization_error kind will encompass any of these variations of errors that come from external problems.
Right now, we also have in insufficient_liquidity in form_error. I think this should on the initialization category also. But that depends on how the google analytics use that value already.

@ebma
Copy link
Member

ebma commented Jan 21, 2025

I think insuffiicient_liquidity can stay on the form_error as you will only face this error when you enter a specific amount into the form. So there has to be some form of interaction whereas for the initialization errors, there's not.

@gianfra-t gianfra-t linked a pull request Jan 21, 2025 that will close this issue
@gianfra-t gianfra-t linked a pull request Jan 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants