Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PEAUTY-239] Addy: Development Environment Setup for Collaboration #94

Merged
merged 7 commits into from
Dec 16, 2024
Merged

[PEAUTY-239] Addy: Development Environment Setup for Collaboration #94

merged 7 commits into from
Dec 16, 2024

Conversation

harvartz
Copy link
Contributor

@harvartz harvartz commented Dec 15, 2024 •
edited
Loading

πŸ“„ [PF-239] Addy: Development Environment Setup for Collaboration

Jira : [PEAUTY-239]("지라 κ³ μž₯남")

✨ λ³€κ²½ 사항

  • κΈ°λŠ₯ μΆ”κ°€/λ³€κ²½ μ„€λͺ…
  • 버그 μˆ˜μ • μ„€λͺ…
  • λ¬Έμ„œ μˆ˜μ • μ„€λͺ…
  • ν˜‘μ—…μ„ μœ„ν•΄ Addy μΈν„°νŽ˜μ΄μŠ€ 및 κ΄€λ ¨ κΈ°λŠ₯듀에 λŒ€ν•œ 것을 κ°œλ°œν–ˆμŠ΅λ‹ˆλ‹€.
  • feign config 의 ν™˜κ²½λ³€μˆ˜κ°€ 잘 μ½ν˜€μ§€μ§€ μ•ŠλŠ” μ—λŸ¬κ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€λ§Œ ν•œλ²ˆ ν™•μΈν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€.
  • Dalle Port에 sendImageToMasking(), sendImageToDalle() λ©”μ„œλ“œλ₯Ό μ„ μ–Έν•˜μ—¬ ν•˜λ‚˜ μ”© κ°œλ°œν•  μ˜ˆμ •μž…λ‹ˆλ‹€.
  • AddyEntityκ°€ PuppyνŒ¨ν‚€μ§€μ— μžˆμ–΄μ„œ AddyνŒ¨ν‚€μ§€λ‘œ μ΄λ™ν–ˆμŠ΅λ‹ˆλ‹€.
  • dto의 경우 일단 μž„μ˜μ μœΌλ‘œ μ„€μ •ν–ˆμœΌλ©° 좔가적인 μˆ˜μ •μ΄ ν•„μš”ν•©λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ 컨트둀러λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. 기쑴의 DTOλ₯Ό μž¬μ‚¬μš©ν•˜μ˜€μœΌλ‚˜ ν•„μš”ν•˜λ©΄ μƒˆλ‘œμš΄ DTOλ₯Ό λ§Œλ“œλŠ” 것이 μ’‹μ•„λ³΄μž…λ‹ˆλ‹€.

πŸ“… μž‘μ—… 일정

  • Expected MD: 0.3MD
  • Actual MD: 0.3MD

Difference reason (If correct, no need.)

  • None.

βœ”οΈ 확인 사항

  • μ½”λ“œκ°€ 잘 μž‘λ™ν•˜λŠ”μ§€ ν™•μΈν–ˆλ‚˜μš”?
  • μƒˆλ‘œμš΄ κΈ°λŠ₯에 λŒ€ν•œ ν…ŒμŠ€νŠΈκ°€ μΆ”κ°€λ˜μ—ˆλ‚˜μš”?
  • λ¬Έμ„œκ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆλ‚˜μš”?

@harvartz
feat: AddyEntityλ₯Ό PuppyνŒ¨ν‚€μ§€ -> AddyνŒ¨ν‚€μ§€ 이동
6aac307
@harvartz
feat: ν™˜κ²½ λ³€μˆ˜ 파일 인식 μ„ΈνŒ…
2037da2
@harvartz
feat: addy api 섀계
8b5349e 
- ν˜‘μ—…μ„ μœ„ν•œ μΈν„°νŽ˜μ΄μŠ€ 섀계
- ν•„μš”ν•œ DTO, Controller, port, adapter μΈν„°νŽ˜μ΄μŠ€, 클래슀 생성
@harvartz
docs: import ꡬ문 정리
b95cbc7
@harvartz harvartz added the πŸ› οΈ κΈ°λŠ₯ New feature or request label Dec 15, 2024
@harvartz harvartz requested a review from Shanate December 15, 2024 08:11
@harvartz harvartz self-assigned this Dec 15, 2024
@harvartz harvartz requested a review from weejinyoung December 15, 2024 08:26
Shanate
Shanate approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@Shanate Shanate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 λ˜μ—ˆμœΌλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€.

peauty-addy/src/main/java/com/peauty/addy/dalle/DalleClientImpl.java
@Component
public class DalleClientImpl implements DalleClient {
@Override
public DalleEditImageResponse editImage(MultipartFile image, MultipartFile mask, String model, String prompt, Integer n, String size, String bearerToken) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ΅¬λ‘λ‘œ 리뷰 λ°›μ•˜μŠ΅λ‹ˆλ‹€.

...c/main/java/com/peauty/customer/presentation/controller/Addy/dto/CreateAddyImageRequest.java Outdated
int x3, int y3,
int x4, int y4,
String prompt,
String bearerToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•΄λ‹Ή 뢀뢄은 같이 μ°Ύμ•„λ³΄κΈ°λ‘œ ν–ˆμŠ΅λ‹ˆλ‹€.

Copy link
Contributor

@Shanate Shanate Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for what: bearerToken
뭘 같이 μ°Ύμ•„λ³΄κΈ°λ‘œ ν–ˆλŠ”μ§€ λͺ…μ‹œλ₯Ό μ•ˆν•΄λ†”μ„œ μžŠμ–΄λ²„λ¦¬κΈ° 전에 μ μ—ˆμŠ΅λ‹ˆλ‹€

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ € 뢀뢄은 μ œκ°€ μž„μ˜μ μœΌλ‘œ 넣은거라 ν•„μš”μ—†μœΌμ‹œλ©΄ μ§€μš°μ‹œλ©΄ λ©λ‹ˆλ‹€. μƒ€λƒνƒ€λ‹˜μ΄ κ°œλ°œν•΄μ•Ό ν•˜λŠ” νŒŒλΌλ―Έν„°κ°€ 변경이 μžˆλ‹€λ©΄ 자유둭게 μˆ˜μ •ν•˜μ‹œλ©΄ λ©λ‹ˆλ‹€.

@harvartz
style: νŒ¨ν‚€μ§€ 이름 λ³€κ²½
8ad8a39
@harvartz
feat: ν…ŒμŠ€νŠΈ 컨트둀러 개발
67349ac 
- λ”°λ‘œ ν…ŒμŠ€νŠΈν•  λ•Œ μ œλŒ€λ‘œ μž‘λ™ν–ˆλŠ”μ§€ ν™•μΈν•˜κΈ° μœ„ν•œ ν…ŒμŠ€νŠΈ μ»¨νŠΈλ‘€λŸ¬μ™€ λ©”μ„œλ“œλ₯Ό κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€.
@myeonginjin
Copy link

ν™”μ΄νŒ…μž…λ‹ˆλ‹€

weejinyoung
weejinyoung approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@weejinyoung weejinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@harvartz harvartz merged commit 37ff12d into release/v0.1.0 Dec 16, 2024
2 checks passed
@weejinyoung weejinyoung deleted the feature/PEAUTY-239 branch December 31, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shanate Shanate Shanate approved these changes

@weejinyoung weejinyoung weejinyoung approved these changes

Assignees

@harvartz harvartz

Labels
πŸ› οΈ κΈ°λŠ₯ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harvartz @myeonginjin @weejinyoung @Shanate