Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEAUTY-199] Workspace Change enum type value (Request(english), Response(korean)) #79

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

harvartz
Copy link
Contributor

@harvartz harvartz commented Dec 12, 2024

๐Ÿ“„ [PF-199] Workspace Change enum type value (Request(english), Response(korean))

Jira : PEAUTY-199

โœจ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ๊ธฐ๋Šฅ ์ถ”๊ฐ€/๋ณ€๊ฒฝ ์„ค๋ช…
  • ๋ฌธ์„œ ์ˆ˜์ • ์„ค๋ช…
  • ์›Œํฌํ”„ํŽ˜์ด์Šค์˜ payemntOption์—์„œ enum ํƒ€์ž…์— ํ•ด๋‹นํ•˜๋Š” dto ๊ฐ’์„ request๋Š” ์˜์–ด๋กœ, response๋Š” ํ•œ๊ธ€๋กœ ๋ณด๋‚ผ ์ˆ˜ ์žˆ๊ฒŒ ์ˆ˜์ •
  • h2 ์‹คํ–‰ ์‹œ ์ˆ˜๋™์œผ๋กœ ๋”๋ฏธ๋ฐ์ดํ„ฐ์— ํ•ด๋‹นํ•˜๋Š” ์ฟผ๋ฆฌ๋ฅผ ์‹คํ–‰ํ–ˆ์œผ๋‚˜ ์ž๋™์œผ๋กœ ์‹คํ–‰๋˜๊ฒŒ application.yml ์ˆ˜์ •

๐Ÿ“… ์ž‘์—… ์ผ์ •

  • Expected MD: 0.1MD
  • Actual MD: 0.1MD

Difference reason (If correct, no need.)

  • None.

โœ”๏ธ ํ™•์ธ ์‚ฌํ•ญ

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์ž‘๋™ํ•˜๋Š”์ง€ ํ™•์ธํ–ˆ๋‚˜์š”?
  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ๋‚˜์š”?
  • ๋ฌธ์„œ๊ฐ€ ์—…๋ฐ์ดํŠธ๋˜์—ˆ๋‚˜์š”?

- ์š”๊ตฌ์‚ฌํ•ญ ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•œ dto ๋ณ€๊ฒฝ
- h2๋Š” ์„œ๋ฒ„ ์‹คํ–‰์‹œ ๋‹ค์‹œ ์ƒˆ๋กœ ์‹œ์ž‘๋˜๊ธฐ ๋•Œ๋ฌธ์— create๋กœ ์ˆ˜์ •
- h2 ์‹คํ–‰ ์‹œ, ์ฟผ๋ฆฌ๋ฌธ ํŒŒ์ผ ์ž๋™ ์‹คํ–‰
@harvartz harvartz added ๐Ÿž ๋ฒ„๊ทธ Something isn't working ๐Ÿ› ๏ธ ๊ธฐ๋Šฅ New feature or request labels Dec 12, 2024
@harvartz harvartz requested a review from Shanate December 12, 2024 02:49
@harvartz harvartz self-assigned this Dec 12, 2024
@harvartz harvartz requested a review from weejinyoung December 12, 2024 02:52
@harvartz harvartz changed the title [PEAUTY-199] Change DTO value (Request(english), Request(korean)) [PEAUTY-199] Workspace Change enum type value (Request(english), Request(korean)) Dec 12, 2024
Copy link
Contributor

@weejinyoung weejinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ์— ๋‹ฌ์•„๋“œ๋ฆฐ ์ฟผ๋ฆฌ ์ฐธ๊ณ ํ•ด์„œ ํ…Œ์ด๋ธ” ์ปฌ๋Ÿผ ์†์„ฑ ๋ฐ”๊ฟ”์ฃผ์„ธ์šฅ

@harvartz harvartz changed the title [PEAUTY-199] Workspace Change enum type value (Request(english), Request(korean)) [PEAUTY-199] Workspace Change enum type value (Request(english), Response(korean)) Dec 12, 2024
@harvartz harvartz merged commit 5388260 into release/v0.1.0 Dec 12, 2024
2 checks passed
@Shanate
Copy link
Contributor

Shanate commented Dec 12, 2024

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

@harvartz harvartz deleted the feature/PEAUTY-199 branch December 12, 2024 08:35
@harvartz harvartz added ๐Ÿ”จ ๋ฆฌํŒฉํ† ๋ง ์š”๊ตฌ์‚ฌํ•ญ ๋ณ€๊ฒฝ์€ ์•„๋‹ˆ์ง€๋งŒ ์ˆ˜์ •ํ•  ์‚ฌํ•ญ์ด ์žˆ์–ด์š” and removed ๐Ÿž ๋ฒ„๊ทธ Something isn't working labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› ๏ธ ๊ธฐ๋Šฅ New feature or request ๐Ÿ”จ ๋ฆฌํŒฉํ† ๋ง ์š”๊ตฌ์‚ฌํ•ญ ๋ณ€๊ฒฝ์€ ์•„๋‹ˆ์ง€๋งŒ ์ˆ˜์ •ํ•  ์‚ฌํ•ญ์ด ์žˆ์–ด์š”
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants