Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password is injected into URL, nothing escaped #41

Open
rubdos opened this issue Nov 13, 2019 · 1 comment
Open

Password is injected into URL, nothing escaped #41

rubdos opened this issue Nov 13, 2019 · 1 comment

Comments

@rubdos
Copy link

rubdos commented Nov 13, 2019

When using a password with characters such as : and @, weird errors are thrown (not finding hostname username), completely unrelated to the issue: the password contains characters that are not escaped in https://github.com/pdmangel/node-red-contrib-openhab2/blob/master/77-openhab2.js#L23

I'm very inexperienced with NodeJS, but I assume it has some functionality to do a proper basic auth, instead of hijacking the URL?

@pdmangel
Copy link
Owner

As a quick fix, version 1.1.7 of node-red-contrib-openhab2 now escapes special characters in username and password properly.
Please feedback your test result in this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants