Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to insert more than one table row at a time #10628

Open
rilrom opened this issue Jan 17, 2025 · 4 comments
Open

Unable to insert more than one table row at a time #10628

rilrom opened this issue Jan 17, 2025 · 4 comments
Labels
created-by: Contributor status: needs-triage Possible bug which hasn't been reproduced yet

Comments

@rilrom
Copy link
Contributor

rilrom commented Jan 17, 2025

Describe the Bug

This is lexical specific bug and has been fixed in v0.22.0. Resolving this on our end would involve upgrading our lexical dependencies to at least v0.22.0.

Additional context can be found in the lexical PR.

Link to the code that reproduces this issue

facebook/lexical#6963

Reproduction Steps

  1. Select multiple rows and open the table action menu.
  2. Select the 'insert XX rows below button.
  3. Notice that only one row is inserted, and it is sometimes in the incorrect spot.

Which area(s) are affected? (Select all that apply)

plugin: richtext-lexical

Environment Info

Payload: 3.17.1
Next.js: 15.1.4
@AlessioGr
Copy link
Member

AlessioGr commented Jan 17, 2025

Resolving this on our end would involve upgrading our lexical dependencies to at least v0.22.0.

This will be tricky, as that might be a breaking change.

We might have to use our own copy of the lexical-table package - same way we did with lexical-markdown

@rilrom
Copy link
Contributor Author

rilrom commented Jan 17, 2025

Resolving this on our end would involve upgrading our lexical dependencies to at least v0.22.0.

This will be tricky, as that might be a breaking change.

We might have to use our own copy of the lexical-table package - same way we did with lexical-markdown

That's unfortunate. Are we stuck on v0.21.0 for the rest of Payload v3?

@AlessioGr
Copy link
Member

That's unfortunate. Are we stuck on v0.21.0 for the rest of Payload v3?

Yep, this will likely be the case

@rilrom
Copy link
Contributor Author

rilrom commented Jan 17, 2025

That's unfortunate. Are we stuck on v0.21.0 for the rest of Payload v3?

Yep, this will likely be the case

Okay, in that case it might be worth exploring removing the ability for more than one row to be inserted with the TableActionMenu plugin, otherwise we're just leaving in broken functionality. Or the alternative of managing our own table package also works, just comes with additional overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Contributor status: needs-triage Possible bug which hasn't been reproduced yet
Projects
None yet
Development

No branches or pull requests

2 participants