Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SCSS to JSS #67

Open
dlabaj opened this issue Feb 28, 2024 · 0 comments
Open

Convert SCSS to JSS #67

dlabaj opened this issue Feb 28, 2024 · 0 comments

Comments

@dlabaj
Copy link
Contributor

dlabaj commented Feb 28, 2024

The build scripts for building CSS from SCSS are causing issues in certain environments where the code is located within another project. The scripts assume that the project will be built as a standalone project.

path.resolve(file.replace('/src/', '/dist/esm/'), './').replace(/scss$/, 'css'),

Instead of updating the files we should convert to JSS to prevent issues caused by using custom script files.

https://cssinjs.org/?v=v10.10.0

This will also help with module federation as it will be one less file to be concerned with when trying to reduce the bundle size of your code.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Mar 29, 2024
@dlabaj dlabaj moved this from Needs triage to Backlog in PatternFly Issues Apr 19, 2024
@dlabaj dlabaj added this to the Prioritized Backlog milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant