Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Fix spacing issue that appears in React and HTML docs #4257

Open
edonehoo opened this issue Sep 13, 2024 · 1 comment · May be fixed by #4397
Open

Bug - Fix spacing issue that appears in React and HTML docs #4257

edonehoo opened this issue Sep 13, 2024 · 1 comment · May be fixed by #4397
Assignees
@wise-king-sullyman @mcoker
Labels
Content
Milestone
2024.Q4

Comments

@edonehoo
Copy link
Collaborator

edonehoo commented Sep 13, 2024 •
edited
Loading

New lines aren't formatted properly in these docs, looks like its due to p.pf-v6-c-content--p.ws-p in a css file

Example (there aren't any new lines when there should be a few paragraph breaks here):
Image
@edonehoo edonehoo self-assigned this Sep 13, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 13, 2024
@edonehoo
Copy link
Collaborator Author

It's true that p.pf-v6-c-content--p.ws-p in mdx.css has a margin set to 0, which is causing this. However, removing it will lead to spacing issues in org docs (too much space). How are React/HTML docs inheriting this class? Can we specify the margin depending on which repo the docs are from? Or update something in packages/documentation-framework/scripts/md/styled-tags.js?

@nicolethoen nicolethoen moved this from Backlog to Ready to assign in PatternFly Issues Oct 7, 2024
@edonehoo edonehoo removed their assignment Oct 21, 2024
@kmcfaul kmcfaul removed the bug label Oct 25, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Nov 20, 2024
@wise-king-sullyman wise-king-sullyman linked a pull request Dec 2, 2024 that will close this issue
Open
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Dec 3, 2024
@mcoker mcoker self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

@mcoker mcoker

Labels
Content
Projects
PatternFly Issues
Status: PR Review
PatternFly Extensions
Status: No status
Milestone
2024.Q4
5 participants
@wise-king-sullyman @nicolethoen @mcoker @kmcfaul @edonehoo