Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is GetOrAdd safe for varying partition sizes within a single driver stage? #959

Open
pgrete opened this issue Oct 18, 2023 · 2 comments
Open
Assignees
Labels
question Further information is requested

Comments

@pgrete
Copy link
Collaborator

pgrete commented Oct 18, 2023

Changing the partition sizes within a driver is generally allowed (currently), but it's unclear of that change is properly reflected in the caching label mechanism.
We/I should double check of there are potential issue as there are/might be places in the code where we implicitly assume a single pack (e.g.. for guaranteed non-blocking reductions across all blocks of a rank).

@pgrete pgrete added the question Further information is requested label Oct 18, 2023
@pgrete pgrete self-assigned this Oct 18, 2023
@Yurlungur
Copy link
Collaborator

This may also be different between sparse and legacy packs (another reason to move to a single codepath at some point)

@pgrete
Copy link
Collaborator Author

pgrete commented Oct 18, 2023

And for the GMG GetOrAdd, see #911 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants