-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store block gid and neighbor refinement levels in sparse packs #1167
Conversation
There's currently no testing for this, I wasn't sure where the best place for unit tests might be. The sparse pack unit test doesn't initialize the necessary data in |
This would obviate #1010 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but a few comments below about how we might save some space or remove the extra deep copy.
Still untested but I did experiment in the |
PR Summary
For certain discrete methods we need to know the refinement level of each cell across a face. This information is not currently available inside compute kernels. This PR add this data to sparse packs, along with the gid of each current block in the pack, which is also needed for certain algorithms.
PR Checklist