Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify treatment of mean molecular mass and temperature #45

Open
forrestglines opened this issue Mar 27, 2023 · 2 comments
Open

Unify treatment of mean molecular mass and temperature #45

forrestglines opened this issue Mar 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@forrestglines
Copy link
Contributor

As mentioned in #2 about src/cluster/agn_triggering.cpp, it would be best to unify treatment of He mass fraction, mean molecular mass, and computing temperature.
@forrestglines forrestglines added the enhancement New feature or request label Mar 27, 2023
@pgrete
Copy link
Contributor

pgrete commented Mar 29, 2023

Tightly couple (if not duplicate of #22) and I'm definitely in favor of this.
We should probably make this happen once the cluster PR is merged as it should be fairly straightforward.

@pgrete
Copy link
Contributor

pgrete commented Aug 21, 2024 •
edited
Loading

This update should also include an input parameter for the Coulomb logarithm (which, e.g., enters the calculation of the thermal conductivity) and more generally unify/check consistency of prefactor in EOS related quantities (there are likely factor unity differences at different places because of the implicit assumption about the plasma composition).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forrestglines @pgrete