Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to bench networking #7278

Open
AndreiEres opened this issue Jan 21, 2025 · 1 comment
Open

Command to bench networking #7278

AndreiEres opened this issue Jan 21, 2025 · 1 comment

Comments

@AndreiEres
Copy link
Contributor

Working on networking in Substrate and Polkadot, it would be very helpful to run benchmarks for a PR. Since we don't need to do this for every run, it could be executed via a bot command.

Here are the commands to run the benchmarks:

cargo bench -p sc-network --bench notifications_protocol -- --output-format bencher
cargo bench -p sc-network --bench request_response_protocol -- --output-format bencher

The output displays the time for 100 messages, but our public charts use values for a single message. It would be helpful if the command output could show the numbers divided by 100.

@paritytech/networking

@mordamax mordamax transferred this issue from paritytech/command-bot Jan 21, 2025
@mordamax
Copy link
Contributor

@AndreiEres transferred to polkadot-sdk, as command-bot is deprecated by now. New command bot is part of polkadot-sdk, and it's open for contributions https://github.com/paritytech/polkadot-sdk/blob/master/.github/scripts/cmd/cmd.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants