Switch runtimes benchmarking for delivering to sibling parachains instead of Parent #7321
+28
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EleisonC
changed the title
|
Hey @bkontur I am Kindly requesting for your feedback on this. PR |
bkontur
requested changes
Jan 24, 2025
| @@ -825,7 +825,7 @@ impl cumulus_pallet_aura_ext::Config for Runtime {} | |||
|
|
|||
| parameter_types! { | |||
| /// The asset ID for the asset that we use to pay for message delivery fees. | |||
| pub FeeAssetId: AssetId = AssetId(xcm_config::WestendLocation::get()); | |||
| pub FeeAssetId: AssetId = AssetId(xcm_config::AssetHubWestend::get()); | |||
There was a problem hiding this comment.
no change here, WestendLocation means Location { parents: 1, interior: Here } which represents relaychain native token from the parachain's perspective, which is WND (or DOT for Polkadot, KSM for Kusama...).
Suggested change
| pub FeeAssetId: AssetId = AssetId(xcm_config::AssetHubWestend::get()); | |
| pub FeeAssetId: AssetId = AssetId(xcm_config::WestendLocation::get()); |
| impl cumulus_pallet_session_benchmarking::Config for Runtime {} | ||
|
|
||
| parameter_types! { | ||
| pub ExistentialDepositAsset: Option<Asset> = Some(( | ||
| WestendLocation::get(), | ||
| AssetHubWestend::get(), |
There was a problem hiding this comment.
Suggested change
| AssetHubWestend::get(), | |
| WestendLocation::get(), |
| ExistentialDeposit::get() | ||
| ).into()); | ||
| pub const RandomParaId: ParaId = ParaId::new(43211234); | ||
| pub const SiblingAssetHubId: ParaId = ParaId::new(AssetHubId::get()); |
There was a problem hiding this comment.
AssetHub does not know any other sibling AssetHub, RandomParaId is good here
Suggested change
| pub const SiblingAssetHubId: ParaId = ParaId::new(AssetHubId::get()); | |
| pub const RandomParaId: ParaId = ParaId::new(43211234); | |
| pub RandomParaLocation: Location = ParentThen(Parachain(RandomParaId::get().into()).into()).into(); |
| @@ -1893,34 +1893,34 @@ impl_runtime_apis! { | |||
| xcm_config::XcmConfig, | |||
| ExistentialDepositAsset, | |||
| PriceForSiblingParachainDelivery, | |||
| RandomParaId, | |||
| SiblingAssetHubId, | |||
There was a problem hiding this comment.
Suggested change
| SiblingAssetHubId, | |
| RandomParaId, |
| ParachainSystem, | ||
| > | ||
| ); | ||
|
|
||
| fn reachable_dest() -> Option<Location> { | ||
| Some(Parent.into()) | ||
| Some(AssetHubWestend::get()) |
There was a problem hiding this comment.
please, everywhere where you changed Location (location and not assetId) Parent to AssetHubWestend, you need to change Parent tot RandomParaLocation
Suggested change
| Some(AssetHubWestend::get()) | |
| Some(RandomParaLocation::get()) |
| xcm_config::XcmConfig, | ||
| ExistentialDepositAsset, | ||
| PriceForSiblingParachainDelivery, | ||
| SiblingAssetHubId, |
There was a problem hiding this comment.
Suggested change
| SiblingAssetHubId, | |
| RandomParaId, |
| fn valid_destination() -> Result<Location, BenchmarkError> { | ||
| Ok(WestendLocation::get()) | ||
| Ok(AssetHubWestend::get()) |
There was a problem hiding this comment.
Suggested change
| Ok(AssetHubWestend::get()) | |
| Ok(RandomParaLocation::get()) |
| @@ -2042,7 +2043,7 @@ impl_runtime_apis! { | |||
| } | |||
| }) | |||
| .chain(core::iter::once(Asset { id: AssetId(Here.into()), fun: Fungible(u128::MAX) })) | |||
| .chain(core::iter::once(Asset { id: AssetId(WestendLocation::get()), fun: Fungible(1_000_000 * UNITS) })) | |||
| .chain(core::iter::once(Asset { id: AssetId(AssetHubWestend::get()), fun: Fungible(1_000_000 * UNITS) })) | |||
There was a problem hiding this comment.
Suggested change
| .chain(core::iter::once(Asset { id: AssetId(AssetHubWestend::get()), fun: Fungible(1_000_000 * UNITS) })) | |
| .chain(core::iter::once(Asset { id: AssetId(WestendLocation::get()), fun: Fungible(1_000_000 * UNITS) })) |
Comment on lines
+2058
to
+2059
| AssetHubWestend::get(), | ||
| Asset { fun: Fungible(UNITS), id: AssetId(AssetHubWestend::get()) }, |
There was a problem hiding this comment.
we want to simulate scenario, where RandomParaLocation can teleport us native token aka WND aka WestendLocation
Suggested change
| AssetHubWestend::get(), | |
| Asset { fun: Fungible(UNITS), id: AssetId(AssetHubWestend::get()) }, | |
| RandomParaLocation::get(), | |
| Asset { fun: Fungible(UNITS), id: AssetId(WestendLocation::get()) }, |
Comment on lines
+67
to
+68
| pub const AssetHubId: u32 = 1000; | ||
| pub const AssetHubWestend: Location = Parachain(AssetHubId::get()).into(); |
There was a problem hiding this comment.
Suggested change
| pub const AssetHubId: u32 = 1000; | |
| pub const AssetHubWestend: Location = Parachain(AssetHubId::get()).into(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Update XCM benchmarks for sibling parachain delivery (closes #7211)
Description:
This PR updates XCM benchmarking configurations for testnet system parachains to reflect delivery to sibling parachains instead of the Parent relay chain.
Integration:
Replaced ToParentDeliveryHelper with ToParachainDeliveryHelper.
Updated benchmark destinations