Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OP payload builder operate on the pooled tx type #13901

Open
mattsse opened this issue Jan 21, 2025 · 0 comments
Open

Make OP payload builder operate on the pooled tx type #13901

mattsse opened this issue Jan 21, 2025 · 0 comments
Assignees
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 21, 2025

Describe the feature

currently the op builder and best_txs operate on the consensus variant:

mut best_txs: impl PayloadTransactions<Transaction = EvmConfig::Transaction>,

impl<T, I> PayloadTransactions for BestPayloadTransactions<T, I>
where
T: PoolTransaction,
I: Iterator<Item = Arc<ValidPoolTransaction<T>>>,
{
type Transaction = T::Consensus;
fn next(&mut self, _ctx: ()) -> Option<Recovered<Self::Transaction>> {
loop {
let tx = self.best.next()?;
if self.invalid.contains(&tx.sender()) {
continue
}
return Some(tx.to_consensus())

however we need info about the pooled tx type for DA #13757 and soon tx conditional

TODO

  • make PayloadTransactions return the validPool tx instead

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 21, 2025
@mattsse mattsse self-assigned this Jan 21, 2025
@mattsse mattsse added A-block-building Related to block building A-tx-pool Related to the transaction mempool A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant