-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make regeneration not override nodes by default #6
Comments
Correct me if wrong but if changing the prompt of a node in the middle of a tree creates new children nodes, once regeneration occurs the history / lineage of the previous ones is not going to be accurate anymore (also related to #7). This could lead to confusion or incorrect assumptions. Note that this is already the case for:
So thinking it might be desirable to:
And going back to the issue at hand, if we don't want to partially invalidate the tree while regenerating without overriding, the ideal solution should be
|
yup this is definitely the case, but i'd consider this more of a design choice than a bug or something to be addressed with a lot of complexity. flux is a power tool for power users. there are valid cases where you might want to retroactively edit and prune the tree, even if that means the tree as it stands is not reproducible/deterministic. we provide people with all the tools to do things like this and make adjacent nodes for branching, overriding, etc if that's the behavior they want. so in terms of this:
i do think this is one path we could go, but personally i think we should make this a path users can take if they want (by creating a new sibling node themselves with the new prompt, etc) but not force it upon them. willing to reconsider down the line, but this is my take rn |
Yes I agree. It definitely feels secondary, so not worth the increase in complexity and edge cases to handle this would come with. |
can add a new keybind to do overriding
https://twitter.com/spring_stream/status/1640824513213652992?s=20
The text was updated successfully, but these errors were encountered: