Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake build system? #25

Closed
jlblancoc opened this issue Aug 22, 2020 · 3 comments · Fixed by #32
Closed

Add CMake build system? #25

jlblancoc opened this issue Aug 22, 2020 · 3 comments · Fixed by #32

Comments

@jlblancoc
Copy link
Contributor

It would be great to have this awesome project ported to CMake, for easier integration with other tools, and probably as a first step to solve #10 too.

My initial attempt (working for the library itself for now) is here, for your reference: https://github.com/MRPT/libfyaml/commit/75addc8ec95a55eeb9339519d28f85887b748bc2

@stilgarpl
Copy link

stilgarpl commented Jan 21, 2021

@jlblancoc This cmake file looks good, but you should add CONFIGURE_DEPENDS flag to your file(GLOB*), so that it could correctly find files that were changed after the first build.
Also, you should make a pull request for this.

@jlblancoc
Copy link
Contributor Author

Awesome! I didn't know the flag CONFIGURE_DEPENDS. It was apparently added to CMake >= 3.12.

@pantoniou
Copy link
Owner

I'm merging this. It's been a long time in my TODOs but never got enough time to do it.
If you could please add some rules to build fy-tool it would be appreciated.

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants