Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajax Endpoint Refactoring #415

Open
EdwardBock opened this issue Sep 2, 2016 · 3 comments
Open

Ajax Endpoint Refactoring #415

EdwardBock opened this issue Sep 2, 2016 · 3 comments
Assignees
Milestone

Comments

@EdwardBock
Copy link
Member

We habe an ajax class that handles all requests and invoke the methods by parameters. That's nice but we come to the point where it gets really big.

I'd like an refactring where we have an ajax class implementation thats pluggable. like we have for grid boxes. So if we need more ajax calls for whatever we can create an class and by convetion it's methods are called by parameters.

Good idea?

@EdwardBock EdwardBock added this to the Grid Refactoring milestone Sep 23, 2016
@mkernel mkernel modified the milestones: Grid 2.0 Refactoring, Powerday Oct 4, 2016
@EdwardBock
Copy link
Member Author

@mkernel

I tried a post reqest with component: "grid.test" and method "allMethods" and got the answer "no component found". When I start the debugger $this->components is null.

https://github.com/palasthotel/grid/blob/react/classes/grid_ajaxendpoint.php#L42

@mkernel
Copy link
Contributor

mkernel commented Oct 4, 2016

I'll have a look.

@mkernel
Copy link
Contributor

mkernel commented Oct 4, 2016

@EdwardBock fixed the constructor calls - the ajax endpoint now has a constructor. not calling it will result in the bug you saw.

@mkernel mkernel assigned EdwardBock and unassigned mkernel Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants