Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java samples - root/welcome page #750

Open
pacostas opened this issue Jul 12, 2024 · 1 comment
Open

Java samples - root/welcome page #750

pacostas opened this issue Jul 12, 2024 · 1 comment
Labels
enhancement New feature or request java Pull requests that update Java code

Comments

@pacostas
Copy link
Contributor

Describe the Enhancement

The Java samples do not have a landing page similar to the Node.js samples.

Possible Solution

Add a controller to all the Java samples that will serve under the / endpoint below HTML page

samples/nodejs/npm/server.js

Lines 7 to 15 in 2fedfba

response.send(`<!DOCTYPE html>
<html>
<head>
<title>Powered By Paketo Buildpacks</title>
</head>
<body>
<img style="display: block; margin-left: auto; margin-right: auto; width: 50%;" src="https://paketo.io/images/paketo-logo-full-color.png"></img>
</body>
</html>`);

Motivation
@pacostas pacostas added java Pull requests that update Java code enhancement New feature or request labels Jul 12, 2024
@dmikusa
Copy link
Contributor

dmikusa commented Jul 12, 2024

Sounds reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmikusa @pacostas