-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenTelemetry extension to allow auto-instrumentation #784
feat: Add OpenTelemetry extension to allow auto-instrumentation #784
Conversation
@sophiewigmore - I'm not sure how to set the labels 🤔 |
Hi @cedricziel thanks for the PR. This change seems reasonable, however you'll need to add it to the extension lists in the files here as well: https://github.com/paketo-buildpacks/php-dist/tree/f0fcf6a87f5304092f826e192a287951d5ed3684/dependency/actions/compile/extensions-manifests. Make sure that the extension version is compatible with the version of PHP that corresponds to the extension file |
@sophiewigmore done 👍 ext-opentelemetry is compatible with php >= 8 so I added it to all 3 manifests. |
@cedricziel cool! thanks. can you please edit the PR to point to this new branch I've made? https://github.com/paketo-buildpacks/php-dist/tree/opentelemetry Since this affects the dependency compilation code, I want to push it to a branch on this repository so we can check it works in our dependency update Github action first. We can do that by triggering it off that branch and seeing all of our tests go green with the resulting dependencies |
In thinking about doing that, I just realized we also test the compiled PHP dependency and check the extensions, so you may need to update the tests/fixtures here to include the new extension: https://github.com/paketo-buildpacks/php-dist/tree/95ca8b063cc3511e4dcb319d83dd802ec4997ef8/dependency/test |
@sophiewigmore added them to the test apps and retargeted the branch |
268128f
into
paketo-buildpacks:opentelemetry
* feat: Add OpenTelemetry extension to allow auto-instrumentation * add extension to 2nd manifest * use pecl recipe * add ext-opentelemetry to manifests * Add ext-opentelemetry to test app --------- Co-authored-by: Sophie Wigmore <[email protected]>
@cedricziel re-testing here with an automation fix - https://github.com/paketo-buildpacks/php-dist/actions/runs/10905342607 |
* feat: Add OpenTelemetry extension to allow auto-instrumentation (#784) * feat: Add OpenTelemetry extension to allow auto-instrumentation * add extension to 2nd manifest * use pecl recipe * add ext-opentelemetry to manifests * Add ext-opentelemetry to test app --------- Co-authored-by: Sophie Wigmore <[email protected]> * remove some versions for re-compilation * Updating buildpack.toml with new versions 8.2.19, 8.3.7, 8.1.28 --------- Co-authored-by: Cedric Ziel <[email protected]> Co-authored-by: Sophie Wigmore <[email protected]>
Summary
Add the open telemetry php extension via pecl
Use Cases
Enable observability for PHP apps built with the CNB
Checklist
Closes: #785