Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dependency management workflow #470

Open
2 tasks
TisVictress opened this issue Dec 5, 2022 · 0 comments · May be fixed by #502
Open
2 tasks

Refactor dependency management workflow #470

TisVictress opened this issue Dec 5, 2022 · 0 comments · May be fixed by #502
Assignees

Comments

@TisVictress
Copy link
Contributor

In an effort to make PHP compatible with Jammy, we've copied the binary-builder code from dep-server directly into this buildpack's dependency management workflow. See this comment for more context. This is not ideal because the binary-builder code is superfluous and hard to maintain.

Keeping the binary-builder code as is also created sudo-related issues that made it difficult to run commands within the compilation container. As a result, a docker user was created as a hack. This is not a long term solution.

Acceptance Criteria:

  • remove binary-builder directory from dependency/actions/compile
  • remove docker user form sudo-ers group and remove --env PASSWORD=docker from action.yml
@TisVictress TisVictress moved this to ❓Not scoped in Paketo Workstreams Dec 5, 2022
@thitch97 thitch97 moved this from ❓Not scoped to 📝 Todo in Paketo Workstreams Dec 19, 2022
@TisVictress TisVictress self-assigned this Jan 3, 2023
@TisVictress TisVictress moved this from 📝 Todo to 🚧 In Progress in Paketo Workstreams Jan 3, 2023
@TisVictress TisVictress linked a pull request Feb 9, 2023 that will close this issue
@TisVictress TisVictress moved this from 🚧 In Progress to 📨 PR Opened in Paketo Workstreams Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📨 PR Opened
Development

Successfully merging a pull request may close this issue.

1 participant