Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all map polygons in feature/station criteria #45

Closed
jameshiebert opened this issue Nov 1, 2019 · 6 comments · Fixed by #63
Closed

Include all map polygons in feature/station criteria #45

jameshiebert opened this issue Nov 1, 2019 · 6 comments · Fixed by #63
Assignees

Comments

@jameshiebert
Copy link
Contributor

Related to #43, the current PCDS portal allows for multiple polygons to be drawn on the map and included in the station filter criteria.

Presently, the current UI allows the user to draw multiple polygons, but only uses the first one in the filter criteria. This should be amended.

@jameshiebert
Copy link
Contributor Author

Another consequence of this issue is that, the spatial selection that gets submitted to the PCDS portal does not comply with the PCDS portal's current expectation. The PCDS portal expects a MULTIPOLYGON and does not match a single POLYGON. So until this issues is fixed, the station-data-portal cannot do any spatial filtering for data requests.

@corviday
Copy link
Contributor

Hopefully updating this function is all that will be required.

@rod-glover
Copy link
Contributor

I believe recent changes have reverted to single polygon.

@jameshiebert
Copy link
Contributor Author

Why so?

@rod-glover
Copy link
Contributor

Because I changed it without realizing it was important during that work. The code was originally adapted from Climate Explorer, which explicitly restricts polygons to just 1 (for reasons I do not remember at the moment). Code for that remained in place, and I used it, evidently erroneously. I think it's a simple matter to fix, not certain yet.

@rod-glover
Copy link
Contributor

Resolved by #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants