Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review date filter logic #1

Open
jameshiebert opened this issue May 30, 2019 · 2 comments
Open

Review date filter logic #1

jameshiebert opened this issue May 30, 2019 · 2 comments

Comments

@jameshiebert
Copy link
Contributor

The date filter logic at present only selects date ranges where the selection range is fully within the range of observations. I'm not sure if that's what we want (and I'm also not sure whether that's congruent with the logic in the BC PCDS portal.

Additionally, the exclusion of stations where {min,max}_obs_time is NULL is not correct.

We should review this collaboratively.

@rod-glover
Copy link
Contributor

@jameshiebert , this would be an opportune time to review this, if you are available.

@rod-glover
Copy link
Contributor

Caution regarding using Station.min_obs_time and Station.max_obs_time, as the frontend currently does for filtering by date. See pacificclimate/pycds#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants