From 6d600d00441901c2787c37de88fc7cbd2a7ffd30 Mon Sep 17 00:00:00 2001 From: Ike Saunders Date: Mon, 22 Jan 2024 21:04:10 +0000 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=8E=89=20add=20aria=20labels=20to=20n?= =?UTF-8?q?av=20buttons?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- site/SiteMobileCategory.tsx | 3 +++ site/SiteMobileMenu.tsx | 1 + site/SiteNavigation.tsx | 4 ++++ site/SiteNavigationToggle.tsx | 3 +++ 4 files changed, 11 insertions(+) diff --git a/site/SiteMobileCategory.tsx b/site/SiteMobileCategory.tsx index f5bb4451cf8..b4be790be57 100644 --- a/site/SiteMobileCategory.tsx +++ b/site/SiteMobileCategory.tsx @@ -28,6 +28,9 @@ export const SiteMobileCategory = ({ ref={categoryRef} > toggleCategory(category)} dropdown={ diff --git a/site/SiteMobileMenu.tsx b/site/SiteMobileMenu.tsx index 1166fbbe3ea..09fd1d1b94f 100644 --- a/site/SiteMobileMenu.tsx +++ b/site/SiteMobileMenu.tsx @@ -51,6 +51,7 @@ export const SiteMobileMenu = ({
  • toggleMenu( diff --git a/site/SiteNavigation.tsx b/site/SiteNavigation.tsx index 0f799f90694..5cd2b2111ad 100644 --- a/site/SiteNavigation.tsx +++ b/site/SiteNavigation.tsx @@ -128,6 +128,7 @@ export const SiteNavigation = ({ })} > toggleMenu(Menu.Topics)} className="SiteNavigationToggle--mobile-menu hide-sm-up" @@ -149,6 +150,7 @@ export const SiteNavigation = ({
    • toggleMenu(Menu.Topics)} dropdown={ @@ -172,6 +174,7 @@ export const SiteNavigation = ({
    • toggleMenu(Menu.Resources) @@ -194,6 +197,7 @@ export const SiteNavigation = ({ onActivate={setSearchAsActiveMenu} /> toggleMenu(Menu.Subscribe)} dropdown={ diff --git a/site/SiteNavigationToggle.tsx b/site/SiteNavigationToggle.tsx index debc80c2e5c..2d3ae0e08da 100644 --- a/site/SiteNavigationToggle.tsx +++ b/site/SiteNavigationToggle.tsx @@ -4,6 +4,7 @@ import { faCaretDown, faCaretUp } from "@fortawesome/free-solid-svg-icons" import cx from "classnames" export const SiteNavigationToggle = ({ + ariaLabel, children, isActive, onToggle, @@ -11,6 +12,7 @@ export const SiteNavigationToggle = ({ dropdown, className, }: { + ariaLabel: string children: React.ReactNode isActive: boolean onToggle: () => void @@ -25,6 +27,7 @@ export const SiteNavigationToggle = ({ })} > @@ -276,7 +276,11 @@ export class FeedbackForm extends React.Component<{ ) : undefined}
      -
      @@ -330,11 +334,16 @@ export class FeedbackPrompt extends React.Component { {this.isOpen ? ( - ) : ( ) : ( @@ -136,6 +140,7 @@ export const NewsletterSubscriptionForm = ({ name="EMAIL" /> diff --git a/site/SiteNavigationTopics.tsx b/site/SiteNavigationTopics.tsx index f147a6eb46a..0970b7ddc7a 100644 --- a/site/SiteNavigationTopics.tsx +++ b/site/SiteNavigationTopics.tsx @@ -60,6 +60,7 @@ export const SiteNavigationTopics = ({ {topics.map((category) => (
    • + )} ) @@ -188,6 +190,7 @@ function Filters({ className="search-filters__tab" >