-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README bug on the running of tests #3328
Comments
Hi @paul-hammant,
Am I right when I assume you don't have JSON support?
Which tests were failed? I assume all of them need JSON... bet please let us know. |
Scanning the README: I'm not sure how to setup
It appears it was already installed on this Ubuntu 24.04 box. There must be some other thing I need? |
I assume you also have Could you show us the output of configure script? At the end it shows up you a summary. Something like this:
|
Was also installed already:
From
|
Thanks, now if you build the source, are you able to run tests? If yes, which tests are failed? |
Same terminal as above, and changing ...
... to ...
I see ...
And ...
|
Ah, thanks - now I see, your regression tests are passed (all of them), but you have 11 failed unit tests. Unfortunately that's an "old" issue, I don't remember when did it brake. But you don't need to run that - if you want to check the library, it's enough to run make check in source root directory after the build process. |
That does indeed run the tests, and they pass for me. Should the readme lose:
And gain instead:
Thanks for you advice here. |
Describe the bug
In the readme, there's advice for
The second line should be
$ ./regression_tests
(underscore not dash), but I can't intuit how to run the unit tests, but am sure thattests/unit-tests
doesn't exist anymore. There is atest-suite.sh
in the same folder this is what I get without any params passed to it:OK, after a fresh clone-recursive I get back to attempting to run
/test$ ./test_suite.sh
again and it completes: "Ran a total of: 4326 unit tests - 11 failed." Not sure of zero failures was expected but 11 is better than 4326 failures.The text was updated successfully, but these errors were encountered: