Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager-components]: <Price /> custom text #13930

Open
1 task done
tristanwagner opened this issue Nov 5, 2024 · 2 comments
Open
1 task done

[manager-components]: <Price /> custom text #13930

tristanwagner opened this issue Nov 5, 2024 · 2 comments

Comments

@tristanwagner
Copy link
Contributor

tristanwagner commented Nov 5, 2024

Have you already checked if a similar item is present on manager-components?

  • Yes, I have already checked the existing components/hooks/utils.

What do you expect from this request?

Component

Description

Right now the <Price /> component supports the generation of a text with differents interval units etc like this

image

I think it should also allow to add additional text content to the label to specify additional information for example

image

To me we should be allowed to pass a React children that will be added to this part of the component, and it should display weither or not there is an intervalUnit prop defined. This will had a lot of flexibility to this component

That additional feature will allow me to reproduce this figma design:

Screenshot 2024-11-05 at 10 40 14

Where do you expect to use this?

@ovh-ux/manager-zimbra-ap

Do you have mock-up?

linked

When do you expect this to be delivered?

ASAP

Additional Information

No response

@anooparveti
Copy link
Contributor

Screenshot 2024-11-27 at 5 43 50 PM
Screenshot 2024-11-27 at 5 45 05 PM
Considering we cannot have same desired content due to localisation (refer attachments), price compute part will be extracted to hook to accommodate the custom cases and used in the price component to enable sharing the code.

@tristanwagner
Copy link
Contributor Author

not sure how to handle this since it kinda conflicts and duplicate between this Price component and the useCatalogPrice hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants