[manager-components]: refactor useIceberg hooks

[tristanwagner]

Have you already checked if a similar item is present on manager-components?

• Yes, I have already checked the existing components/hooks/utils.

What do you expect from this request?

Hooks useIcebergV2, useIcebergV6, useResourcesV6..

Description

Right now I feel like these hooks that extends the useInfiniteQuery calls provide not enough value and also are very restraining for the end user of the hook, I propose that we update the way of exposing this kind of hooks in a more generic and versatile way, that will allow developers to be able to use more of the react-query features for their usecases.

To illustrate by an example, to me an updated version of the hook would look like that:

export function useResourcesIcebergV2<T = unknown>({
  route,
  pageSize = defaultPageSize,
  ...options
}: IcebergFetchParamsV2 & IcebergV2Hook) {
  return useInfiniteQuery({
    initialPageParam: null,
    queryFn: ({ pageParam }) =>
      fetchIcebergV2<T>({ route, pageSize, cursor: pageParam }),
    getNextPageParam: (lastPage) => lastPage.cursorNext,
    select: (data) => { ...data, flattenData},
    ...options,
  });
}

If you really want to flatten the data in there (to me that should not be the place where you should do this but maybe I'm wrong) then you should do it using the select option from useInfiniteQuery and avoid at all cost using a useState in this place.

I want to add that the way the cursor are designed in the APIs, if you use refetch or like refetchInterval feature, when refetching the data, a new cursor will be provided by the API even tho your actual response payload didn't changed so your data object returned will have changed since it contains pageParams that will contain the current cursor, causing unwanted rerenders in your UI, you can avoid this by omitting the cursor in the data.pageParams using select.

To me it also applies to any other hook that will wrap a useQuery or useInfiniteQuery call: you should be able to pass additional options and also retrieve the returns from the call.

Where do you expect to use this?

any

Do you have mock-up?

No response

When do you expect this to be delivered?

ASAP

Additional Information

No response

[tristanwagner]

linked to #13513 #13331

[anooparveti]

The change is no longer needed

From the requester. @pauldkn

[pauldkn]

The change is no longer needed

From the requester. @pauldkn

@anooparveti the #13513 is no longer needed because this one exist and cover a more complete scope on this hook.
I closed the smallest one but this one should still be open