Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the platform decide where to take the user #87

Closed
CodeWithEmad opened this issue Jun 10, 2024 · 0 comments
Closed

Let the platform decide where to take the user #87

CodeWithEmad opened this issue Jun 10, 2024 · 0 comments

Comments

@CodeWithEmad
Copy link
Member

CodeWithEmad commented Jun 10, 2024

Hi.
I don't think that this is not a big issue but we should let the platform decide where to take the user since we can change the login. I believe checking for should_redirect_to_authn_mfe is happening in the edx-platform and there's no need for that

% if should_redirect_to_authn_mfe:
<div class="mobile-nav-item hidden-mobile nav-item">
<a class="register-btn btn" href="${settings.AUTHN_MICROFRONTEND_URL}/register${login_query()}">${_("Register for free")}</a>
</div>
% else:
<div class="mobile-nav-item hidden-mobile nav-item">
<a class="register-btn btn" href="/register${login_query()}">${_("Register for free")}</a>
</div>
% endif
% endif
% if should_redirect_to_authn_mfe:
<div class="mobile-nav-item hidden-mobile nav-item">
<a class="sign-in-btn btn" href="${settings.AUTHN_MICROFRONTEND_URL}/login${login_query()}">${_("Sign in")}</a>
</div>
% else:
<div class="mobile-nav-item hidden-mobile nav-item">
<a class="sign-in-btn btn" href="/login${login_query()}">${_("Sign in")}</a>
</div>
% endif

for example, if you set THIRD_PARTY_AUTH_HINT to your tpa slug, /login will take you to that page, instead of login in authn MFE.

@DawoudSheraz DawoudSheraz moved this from Pending Triage to Backlog in Tutor project management Jun 11, 2024
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 12, 2024
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.

Close overhangio#87
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 12, 2024
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.

Close overhangio#87
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 14, 2024
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.

Close overhangio#87
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 14, 2024
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.

Close overhangio#87
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 14, 2024
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.

Close overhangio#87
CodeWithEmad added a commit to CodeWithEmad/tutor-indigo that referenced this issue Jun 14, 2024
We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login.

Close overhangio#87
@github-project-automation github-project-automation bot moved this from Backlog to Done in Tutor project management Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant