Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make containers independent of slot #1878

Closed
newbialywhodis opened this issue Feb 2, 2025 · 1 comment
Closed

Make containers independent of slot #1878

newbialywhodis opened this issue Feb 2, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@newbialywhodis
Copy link

Is your feature request related to a problem? Please describe.
I really like the way that containers are just stashes assigned to specified item. However I would really love to have opportunity to open the container while not having it equipped by passing its id. It’s gamechanger.

Describe the solution you'd like
Allow containers to be opened while not in eq by their id.

Describe alternatives you've considered
I was thinking about making actually new inventory type and assign stash to item

Additional context
🤝

@newbialywhodis newbialywhodis added the enhancement New feature or request label Feb 2, 2025
@thelindat
Copy link
Member

thelindat commented Feb 2, 2025

#1699

Just a note that this is not simple as it sounds, because the container is bound to a unique id that exists only on the item and that item exists only within an inventory. We can't determine what kind of container it is (what item) to set weight, slots, etc.

It is possible to query that information, but that cannot be achieved efficiently because

  • we will need to perform full table-reads (there is no indexing available for inventory items)
  • we will need to use inefficient json_extract (or similar) functions to find an item with that metadata

If you have one inventory containing 6 items this isn't a big deal... if you have 1000 inventories containing up to 500 items each, we might as well set a bomb off in the server room.

@thelindat thelindat closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants