Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member edit doesn't submit on enter #233

Open
alexdor opened this issue Feb 25, 2019 · 4 comments
Open

Member edit doesn't submit on enter #233

alexdor opened this issue Feb 25, 2019 · 4 comments
Labels
question Further information is requested

Comments

@alexdor
Copy link
Member

alexdor commented Feb 25, 2019

Editing the member's page and hitting enter doesn't submit the changes
@alexdor alexdor added the bug Something isn't working label Feb 25, 2019
@iropal
Copy link
Collaborator

iropal commented Feb 25, 2019

@alexdor it does submit if the submit button is focused.

@alexdor
Copy link
Member Author

alexdor commented Feb 25, 2019 •
edited
Loading

I think it should submit even if the submit button isn't focused, at least for me that is the expected ux as a user. Do you think that it's bad ux?

@iropal
Copy link
Collaborator

iropal commented Feb 25, 2019

Yes because there are multiple functionalities on this page related to enter and we have the close option for the form as well. I think it would be confusing, especially of we take accessibility into account.

@alexdor alexdor added question Further information is requested and removed bug Something isn't working labels Feb 25, 2019
@alexdor
Copy link
Member Author

alexdor commented Feb 25, 2019

@bacharakis thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iropal @alexdor