-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a docker registry for E2E tests #3752
Comments
We build a docker image for main on most commits. Cref: #2264 (comment) Its a bit unclear to me though, looking at recent PRs, seems like a lot don't have this build step that we want to make faster. But some still do at 2.5 minutes (#2264 (comment)) (EDIT: And some at 4.5 minutes (https://github.com/osmosis-labs/osmosis/actions/runs/3716362935/jobs/6302602855)) So we want to speed that up. The idea of this issue, is:
Unassigning myself though, would love if someone can work on it though! |
@niccoloraspa I don't think this is high priority, but mentioning you here since you probably are interested in this particular issue |
What exactly should be done in this issue for it to be addressed? If it's undefined, can we close it? The description and Dev's comment seem to talk about different things. Unfortunately, we cannot post the image to the docker registry because we must make sure that we are running an e2e test for the current commit version of Osmosis. The only possible mitigation strategies that I'm aware of are the following:
So, as far as I understand, we already apply all possible mitigation strategies |
Closing this in favor of other speed up ideas |
Background
You can't cache docker builds on CI and building it on every run makes it much slower.
Suggested Design
We can modify CI to use an osmosis docker registry so that the builds get posted there and get pulled if there are no changes.
Acceptance Criteria
E2E tests run faster
The text was updated successfully, but these errors were encountered: